Bump cffi for the :default library lookup fix#1795
Open
dg1sbg wants to merge 1 commit into
Open
Conversation
CFFI passes :default as the library marker for the default/global namespace, but clasp-ffi:%dlsym only understands :rtld-default and :rtld-next, so cffi:foreign-symbol-pointer without :library always returned NIL on Clasp. cffi/cffi#432 (upstream 8e2928ee) maps :default to :rtld-default in the Clasp backend. Pull it in so cando builds get working struct-by-value support together with the foreign-alloc lifetime fix in this branch.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #1792 (the foreign-alloc lifetime fix, now merged).
Bumps the
:cffipin inrepos.sexpto upstream cffi master8e2928ee, which is the merge of cffi/cffi#432.That commit maps CFFI's
:defaultlibrary marker to:rtld-defaultin the Clasp backend. Without it,cffi:foreign-symbol-pointercalled without an explicit:libraryalways returns NIL on Clasp (clasp-ffi:%dlsymonly understands:rtld-default/:rtld-nextand treats:defaultas a library handle). cffi-libffi'stype-descriptor-ptrdepends on this lookup, so together with #1792 this gives cando builds working struct-by-value support.Verified on macOS arm64 (boehmprecise): full regression suite 1963 pass / 4 fail (all four known-preexisting), plus the cffi-fsbv stress test (300k mixed struct-by-value calls, no crash).